Skip to content

Added keypoint matplotlib viewer#90

Merged
MMathisLab merged 9 commits into
DeepLabCut:mainfrom
hausmanns:seb/matplotlib_keypoint_viewer
Sep 15, 2023
Merged

Added keypoint matplotlib viewer#90
MMathisLab merged 9 commits into
DeepLabCut:mainfrom
hausmanns:seb/matplotlib_keypoint_viewer

Conversation

@hausmanns

@hausmanns hausmanns commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Matplotliib viewer to view your keypoints' trajectory synced with the video and keypoints.

Activate plugin, upload your .h5 (and video, not necessary), and tick "show matplotlib trajectory"

  • Needs a fix: For now it's still hardcoded to the naming of my keypoints of interests.
    Needs to be adapted to keypoints from the GUI directly, in here:

image

napari-deeplabcut-traj_viewer_skeleton.mov

@codecov-commenter

codecov-commenter commented Aug 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #90 (ff625fa) into main (4d34cd2) will decrease coverage by 0.13%.
Report is 6 commits behind head on main.
The diff coverage is 82.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   83.18%   83.05%   -0.13%     
==========================================
  Files          11       11              
  Lines        1540     1688     +148     
==========================================
+ Hits         1281     1402     +121     
- Misses        259      286      +27     
Files Changed Coverage Δ
src/napari_deeplabcut/_widgets.py 73.36% <82.00%> (+1.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deprecated-napari-hub-preview-bot

deprecated-napari-hub-preview-bot Bot commented Aug 30, 2023

Copy link
Copy Markdown

Preview page for your plugin is ready here:
https://preview.napari-hub.org/DeepLabCut/napari-deeplabcut/90
Updated: 2023-08-31T08:05:01.184269

@MMathisLab MMathisLab requested a review from jeylau August 30, 2023 12:29
@jeylau

jeylau commented Aug 31, 2023

Copy link
Copy Markdown
Contributor
demo.mov

@jeylau

jeylau commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Probably a couple of tweaks that could be made here and there; but that works very smoothly even for maDLC.

@hausmanns

hausmanns commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

Another thing that should be tweaked @jeylau :

They y_lim should be independent of the dataset and dependent on the plot window (or adjustable)
Indeed, keypoint jumps can squeeze the window depending on the dataset's quality

@jeylau

jeylau commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Good point; one thing that could be added then is a NavigationToolbar2QT, which would allow panning, zooming, etc.

@MMathisLab

MMathisLab commented Sep 14, 2023

Copy link
Copy Markdown
Member

Is this superseded by #92 ?

@jeylau

jeylau commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

@MMathisLab, these 2 PRs are distinct components. I will add the toolbar Seb mentioned above so this one is ready 😊

@jeylau

jeylau commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Also, regarding the warnings in the console, they will be removed with napari's next release and vispy >= 0.13 napari/napari#6025

@MMathisLab

Copy link
Copy Markdown
Member

I think we need to address failing tests here before merge, right?

@jeylau

jeylau commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Mhhh, napari removed the plugin preview service chanzuckerberg/napari-hub#1216. I'll delete the github action.

@MMathisLab

Copy link
Copy Markdown
Member

so, ready to merge?

@jeylau

jeylau commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

Yes, looking good to me!

@MMathisLab MMathisLab self-requested a review September 15, 2023 14:29
Comment thread setup.cfg Outdated
@MMathisLab MMathisLab merged commit 0e04f2f into DeepLabCut:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants